HDDS-3957. Fix mixed use of Longs.toByteArray and Ints.fromByteArray #1199
+13
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
approved these changes
Jul 14, 2020
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @runzhiwang for fixing this.
Contributor
|
Thanks @runzhiwang for fixing this and @adoroszlai for reviewing it. |
ChenSammi
pushed a commit
that referenced
this pull request
Jul 22, 2020
rakeshadr
pushed a commit
to rakeshadr/hadoop-ozone
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
What's the problem ?
When write
DB_PENDING_DELETE_BLOCK_COUNT_KEYto rocksdb, most code convert value to byte array byLongs.toByteArray. But when read,parseKVContainerDatauseInts.fromByteArray. The result is always wrong, unless the value is zero.For example,
Longs.toByteArray(1)return byte array in which only byte[7] is 1, butInts.fromByteArrayonly parse the first 4 bytes of byte array. So write 1, but read out 0.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3957
How was this patch tested?
add assert in current ut.