Skip to content

Conversation

@lokeshj1703
Copy link
Contributor

What changes were proposed in this pull request?

Enables TestOzoneRpcClientAbstract#testDeletedKeyForGDPR.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3789

How was this patch tested?

Test passes 20 times when run locally

@lokeshj1703 lokeshj1703 self-assigned this Jul 13, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #1198 into master will decrease coverage by 0.19%.
The diff coverage is 55.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1198      +/-   ##
============================================
- Coverage     73.64%   73.45%   -0.20%     
+ Complexity    10063    10035      -28     
============================================
  Files           974      974              
  Lines         49725    49749      +24     
  Branches       4893     4900       +7     
============================================
- Hits          36621    36543      -78     
- Misses        10786    10871      +85     
- Partials       2318     2335      +17     
Impacted Files Coverage Δ Complexity Δ
...che/hadoop/hdds/scm/block/DeletedBlockLogImpl.java 71.23% <0.00%> (-1.37%) 21.00 <0.00> (-1.00)
...m/container/IncrementalContainerReportHandler.java 52.77% <37.50%> (-2.07%) 6.00 <3.00> (ø)
.../hadoop/hdds/scm/container/ReplicationManager.java 87.35% <40.00%> (-0.76%) 102.00 <8.00> (ø)
...oop/hdds/scm/container/ContainerReportHandler.java 86.31% <50.00%> (-2.58%) 16.00 <1.00> (ø)
...on/scm/ReconIncrementalContainerReportHandler.java 60.00% <50.00%> (-1.12%) 4.00 <2.00> (ø)
...rg/apache/hadoop/hdds/scm/node/SCMNodeManager.java 85.53% <68.00%> (-1.76%) 56.00 <4.00> (+1.00) ⬇️
...g/apache/hadoop/hdds/protocol/DatanodeDetails.java 88.97% <100.00%> (+0.08%) 31.00 <0.00> (ø)
...ds/scm/node/states/NodeAlreadyExistsException.java 0.00% <0.00%> (-50.00%) 0.00% <0.00%> (-1.00%)
...doop/ozone/om/exceptions/OMNotLeaderException.java 48.48% <0.00%> (-18.19%) 3.00% <0.00%> (-2.00%)
.../transport/server/ratis/ContainerStateMachine.java 71.74% <0.00%> (-8.30%) 63.00% <0.00%> (-6.00%)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9106f14...4822d12. Read the comment docs.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safe to enable, since it uses STAND_ALONE replication.

20/20 passed: https://github.com/adoroszlai/hadoop-ozone/runs/868707599#step:5:4

@adoroszlai adoroszlai merged commit c6b45ba into apache:master Jul 14, 2020
@adoroszlai
Copy link
Contributor

Thanks @lokeshj1703 for the fix.

ChenSammi pushed a commit that referenced this pull request Jul 22, 2020
rakeshadr pushed a commit to rakeshadr/hadoop-ozone that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants