HDDS-3941. Enable core dump when crash in C++ #1186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The patch looks good to me. + 1. |
ChenSammi
pushed a commit
that referenced
this pull request
Jul 22, 2020
rakeshadr
pushed a commit
to rakeshadr/hadoop-ozone
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
What's the problem ?
This PR is related to HDDS-3933.
When memory leak because of the reason explained in HDDS-3933, Datanode most time generates core.pid because it crash in Rocksdb when create new thread, as the image shows, but generates crash log rarely.
But because the default value of
core file sizeis zero, so core.pid can not be generated. So when Datanode crash in Rocksdb, we can not get any information about why it crashed.How to fix ?
Set
ulimit -c unlimitedto enable core dump when crash in RocksDB.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3941
How was this patch tested?
Existed UT.