Skip to content

Conversation

@avijayanhwx
Copy link
Contributor

What changes were proposed in this pull request?

While writing to secure Ozone s3 gateway, fluentd fails with 500 Error. This happens when there are extra slashes in the requested object path. (More details are in the JIRA)

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3765

How was this patch tested?

Manually tested with fluentd s3 plugin.
Added acceptance tests.

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some aws s3 ls and recursive on the same volume/bucket to see how the output will be shown, when files are created with "//" in the smoke test?

@avijayanhwx
Copy link
Contributor Author

Working with @bharatviswa504 to hash out details in another related JIRA (HDDS-3955). Based on what is decided, this PR may have some changes. Hoping to get this to a resolution in the next few days.

@avijayanhwx
Copy link
Contributor Author

In HDDS-3955 we are adding new logic that "normalizes" the key when intermediate directories need to be created on createKey API. This fix is good to go now.

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@avijayanhwx
Copy link
Contributor Author

Thanks for the review @bharatviswa504.

@avijayanhwx avijayanhwx merged commit d6c7f28 into apache:master Jul 15, 2020
ChenSammi pushed a commit that referenced this pull request Jul 22, 2020
rakeshadr pushed a commit to rakeshadr/hadoop-ozone that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants