Skip to content

Conversation

@ChenSammi
Copy link
Contributor

@ChenSammi ChenSammi commented Nov 5, 2019

What changes were proposed in this pull request?

Support configure multiple raft log storage to host multiple THREE factor RATIS pipelines.
Unless the storage is a fast media, datanode should try best to allocate different raft log storage for new pipeline.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-1576

How this patch can be tested?

?

@ChenSammi ChenSammi requested a review from mukul1987 November 5, 2019 02:10
@xiaoyuyao
Copy link
Contributor

/retest

@xiaoyuyao
Copy link
Contributor

Can you rebase the PR, @ChenSammi ?

@ChenSammi
Copy link
Contributor Author

TestCloseContainerEventHandler#testCloseContainerEventWithRatis cannot be reproduced locally.

@ChenSammi
Copy link
Contributor Author

Hi @mukul1987, would you help to review this patch? The patch is more related with RATIS than Ozone.

count -> Assert.assertEquals(maxPipelinePerNode - 1, count.get()));
}

private void waitForPipelines(int numPipelines)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would good to add a test to verify that even with single ratis directory configured, we are still able to create multiple pipelines as per the limit configured.

Copy link
Contributor Author

@ChenSammi ChenSammi Dec 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @bshashikant , a new commit addressed the concern.

@xiaoyuyao
Copy link
Contributor

I was able to repro and debug the TestCloseContainerEventHandler#testCloseContainerEventWithRatis issue. A proposed fix is commented in #291 for @timmylicheng.

@ChenSammi
Copy link
Contributor Author

Thanks @xiaoyuyao for root cause the failed UT.

@ChenSammi
Copy link
Contributor Author

Failed unit is still testCloseContainerEventWithRatis, which will be addressed in #291 by @timmylicheng

@xiaoyuyao
Copy link
Contributor

Now that #291 is in. Kick start a new run.

@ChenSammi
Copy link
Contributor Author

This time, the failed UT is org.apache.hadoop.ozone.om.TestOzoneManagerHttpServer seems not relevant.

@xiaoyuyao
Copy link
Contributor

Agree, we already have HDDS-2649 tracking the intermittent failures of TestOzoneManagerHttpServer.

+1 for the latest change and I will merge it shortly.

@xiaoyuyao xiaoyuyao merged commit 1938862 into apache:HDDS-1564 Dec 19, 2019
@ChenSammi ChenSammi deleted the HDDS-1576 branch February 20, 2023 03:35
ptlrs pushed a commit to ptlrs/ozone that referenced this pull request Mar 8, 2025
…pache#117)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants