-
Notifications
You must be signed in to change notification settings - Fork 590
HDDS-1576. Support configure more than one raft log storage to host m… #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/retest |
|
Can you rebase the PR, @ChenSammi ? |
…ultiple pipelines.
|
TestCloseContainerEventHandler#testCloseContainerEventWithRatis cannot be reproduced locally. |
|
Hi @mukul1987, would you help to review this patch? The patch is more related with RATIS than Ozone. |
| count -> Assert.assertEquals(maxPipelinePerNode - 1, count.get())); | ||
| } | ||
|
|
||
| private void waitForPipelines(int numPipelines) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would good to add a test to verify that even with single ratis directory configured, we are still able to create multiple pipelines as per the limit configured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure @bshashikant , a new commit addressed the concern.
|
I was able to repro and debug the TestCloseContainerEventHandler#testCloseContainerEventWithRatis issue. A proposed fix is commented in #291 for @timmylicheng. |
|
Thanks @xiaoyuyao for root cause the failed UT. |
|
Failed unit is still testCloseContainerEventWithRatis, which will be addressed in #291 by @timmylicheng |
|
Now that #291 is in. Kick start a new run. |
|
This time, the failed UT is org.apache.hadoop.ozone.om.TestOzoneManagerHttpServer seems not relevant. |
|
Agree, we already have HDDS-2649 tracking the intermittent failures of TestOzoneManagerHttpServer. +1 for the latest change and I will merge it shortly. |
…pache#117) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
What changes were proposed in this pull request?
Support configure multiple raft log storage to host multiple THREE factor RATIS pipelines.
Unless the storage is a fast media, datanode should try best to allocate different raft log storage for new pipeline.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-1576
How this patch can be tested?
?