HDDS-3914. Remove LevelDB configuration option for DN Metastore #1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyuyao
reviewed
Jul 7, 2020
Contributor
xiaoyuyao
left a comment
xiaoyuyao
left a comment
There was a problem hiding this comment.
LGTM overall, a few comments inline...
...service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerCheck.java
Outdated
Show resolved
Hide resolved
Contributor
Author
There was a problem hiding this comment.
For the same reason as above.
Contributor
There was a problem hiding this comment.
The logic needs to be reversed, maybe a typo.
Contributor
Author
There was a problem hiding this comment.
Thanks. Will fix it.
Codecov Report
@@ Coverage Diff @@
## master #1166 +/- ##
============================================
- Coverage 73.49% 73.43% -0.07%
+ Complexity 10051 10032 -19
============================================
Files 974 974
Lines 49731 49729 -2
Branches 4893 4893
============================================
- Hits 36551 36517 -34
- Misses 10858 10877 +19
- Partials 2322 2335 +13
Continue to review full report at Codecov.
|
xiaoyuyao
approved these changes
Jul 10, 2020
Contributor
xiaoyuyao
left a comment
xiaoyuyao
left a comment
There was a problem hiding this comment.
Thanks @hanishakoneru for the update. LGTM, +1.
Contributor
|
@hanishakoneru Thanks for working on this and @xiaoyuyao thanks for the review! |
ChenSammi
pushed a commit
that referenced
this pull request
Jul 22, 2020
rakeshadr
pushed a commit
to rakeshadr/hadoop-ozone
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
LevelDB support was removed for OM and SCM DBs but DN Metastore can still be configured to use LevelDB or RocksDB.
This Jira proposes to remove LevelDB configuration option for DN Metastore (ozone.metastore.impl) and use RocksDB only.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3914
How was this patch tested?
Deprecation patch. No unit tests required.