Skip to content

HDDS-3191: switch from SCMPipelineManager to PipelineManagerV2Impl #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaoyuyao merged 4 commits into from
Jul 14, 2020
Merged

HDDS-3191: switch from SCMPipelineManager to PipelineManagerV2Impl #1151

xiaoyuyao merged 4 commits into from
Jul 14, 2020

Conversation

@GlenGeng-awx
Copy link
Contributor

@GlenGeng-awx GlenGeng-awx commented Jul 1, 2020

What changes were proposed in this pull request?

switch from SCMPipelineManager to PipelineManagerV2Impl.
mainly focus on fixing unit test

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3191

How was this patch tested?

unit tests

@GlenGeng-awx GlenGeng-awx force-pushed the HDDS-3191 branch 3 times, most recently from 285bfd3 to 7469acc Compare July 1, 2020 12:17
@GlenGeng-awx GlenGeng-awx force-pushed the HDDS-3191 branch 7 times, most recently from bf2075e to d4d2a9d Compare July 2, 2020 08:08
@GlenGeng-awx
Copy link
Contributor Author

GlenGeng-awx commented Jul 2, 2020

Hello @elek @adoroszlai Would you please help check a GitHub CI problem ?

I want to push 2 commit from my dev branch GlenGeng:HDDS-3191 to branch apache:HDDS-2823, meanwhile I also tried CI in my personal repo (submit a PR from branch GlenGeng:HDDS-3191 to branch GlenGeng:HDDS-2823, see GlenGeng-awx#2).

It is pretty sure that branch apache:HDDS-2823 is the same as branch GlenGeng:HDDS-2823. I have succeed in my person repo, but failed several time in apache repo.

Seems these failed cases are related to raft leader election, which has randomness. Would you please help have a look ?

Thanks!

@GlenGeng-awx
Copy link
Contributor Author

GlenGeng-awx commented Jul 3, 2020

also see this flaky case failure in master branch

see #1147

xiaoyuyao
xiaoyuyao reviewed Jul 7, 2020
View reviewed changes
hadoop-ozone/recon/pom.xml Outdated
</goals>
<configuration>
<arguments>pnpm config set store-dir ~/.pnpm-store</arguments>
<npmInheritsProxyConfigFromMaven>false</npmInheritsProxyConfigFromMaven>
Copy link
Contributor

@xiaoyuyao xiaoyuyao Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems unrelated. Can you merge it from master?

Copy link
Contributor Author

@GlenGeng-awx GlenGeng-awx Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out! Will drop this change.

@timmylicheng
Copy link
Contributor

timmylicheng commented Jul 8, 2020

LGTM, +1.
See if failed tests can be cleared.

@GlenGeng-awx GlenGeng-awx force-pushed the HDDS-3191 branch 2 times, most recently from bb491e2 to 19c830c Compare July 13, 2020 10:49
@xiaoyuyao
Copy link
Contributor

xiaoyuyao commented Jul 14, 2020

+1, I will merge it shortly.

@xiaoyuyao xiaoyuyao merged commit 8a8c9eb into apache:HDDS-2823 Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaoyuyao xiaoyuyao xiaoyuyao left review comments

Assignees

@GlenGeng-awx GlenGeng-awx

Labels

scm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GlenGeng-awx @timmylicheng @xiaoyuyao