HDDS-3885. Create Datanode home page #1139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maobaolong
force-pushed
the
dnui
branch
2 times, most recently
from
7d0b209 to
9bb9583
Compare
Member
Author
|
@adoroszlai Please take a look at this PR, thanks. |
adoroszlai
reviewed
Jun 30, 2020
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @maobaolong for working on this.
Do you know why Rpc Metrics page is empty for datanode?
hadoop-hdds/container-service/src/main/resources/webapps/hddsDatanode/dn-overview.html
Outdated
Show resolved
Hide resolved
Member
Author
|
@adoroszlai Thanks for your review. AFAIK, the reason why Rpc Metrics page is empty for datanode is that datanode has no rpc service.PTAL. |
Contributor
|
Thanks @maobaolong for updating the patch. Let's wait for others to take a look. |
Member
Author
|
@adoroszlai Thank you for your review. |
Member
Author
|
@xiaoyuyao Please take a look at this PR, if we take this PR into 0.6.0, it would be better, thanks. |
ChenSammi
reviewed
Jul 14, 2020
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@ChenSammi Thank you for correct me, PTAL. |
Contributor
|
Tested it locally. +1. Thanks @maobaolong for the contribution. |
ChenSammi
pushed a commit
that referenced
this pull request
Jul 22, 2020
rakeshadr
pushed a commit
to rakeshadr/hadoop-ozone
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We need a Datanode home page. After this, we can do more effort to see the starttime version, build info and more information about hddsdatanode service.
What is the link to the Apache JIRA
HDDS-3885
How was this patch tested?
start datanode and see the root page.
http://localhost:9882/