Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Currently /retest command creates an empty commit, but unlike manual commits it does not re-trigger CI. It turns out that this is a safety measure on GitHub:

events triggered by the GITHUB_TOKEN will not create a new workflow run

This PR proposes to make /retest command useful by adding a comment to the PR describing steps to trigger CI manually. Actual steps depend on the comment author and PR setting Allow edits and access to secrets by maintainers.

https://issues.apache.org/jira/browse/HDDS-3060

How was this patch tested?

Tested various conditions in my fork.

Copy link
Contributor

@vivekratnavel vivekratnavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@vivekratnavel
Copy link
Contributor

@adoroszlai Thanks for working on this! This will be very helpful.

@vivekratnavel vivekratnavel merged commit 8573e5b into apache:master Jul 14, 2020
@adoroszlai adoroszlai deleted the HDDS-3060 branch July 14, 2020 19:15
@adoroszlai
Copy link
Contributor Author

Thanks @vivekratnavel for reviewing and committing this.

ChenSammi pushed a commit that referenced this pull request Jul 22, 2020
rakeshadr pushed a commit to rakeshadr/hadoop-ozone that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants