Skip to content

HDDS-3847. Change OMNotLeaderException logging to DEBUG #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dineshchitlangia merged 1 commit into from
Jun 24, 2020
+42 −16
Merged

HDDS-3847. Change OMNotLeaderException logging to DEBUG #1118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 42 additions & 16 deletions ...-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/Hadoop3OmTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
package org.apache.hadoop.ozone.om.protocolPB;

import java.io.IOException;
import java.util.ArrayList;
import java.util.List;

import org.apache.hadoop.hdds.conf.ConfigurationSource;
import org.apache.hadoop.hdds.conf.OzoneConfiguration;
Expand Down Expand Up @@ -61,6 +63,7 @@ public class Hadoop3OmTransport implements OmTransport {
private final OMFailoverProxyProvider omFailoverProxyProvider;

private final OzoneManagerProtocolPB rpcProxy;
private List<String> retryExceptions = new ArrayList<>();

public Hadoop3OmTransport(ConfigurationSource conf,
UserGroupInformation ugi, String omServiceId) throws IOException {
Expand Down Expand Up @@ -131,10 +134,11 @@ public RetryAction shouldRetry(Exception exception, int retries,
if (exception instanceof ServiceException) {
OMNotLeaderException notLeaderException =
getNotLeaderException(exception);
if (notLeaderException != null &&
notLeaderException.getSuggestedLeaderNodeId() != null) {
LOG.info("RetryProxy: {}",
notLeaderException.getMessage());
if (notLeaderException != null) {
retryExceptions.add(getExceptionMsg(notLeaderException, failovers));
if (LOG.isDebugEnabled()) {
LOG.debug("RetryProxy: {}", notLeaderException.getMessage());
}

// TODO: NotLeaderException should include the host
// address of the suggested leader along with the nodeID.
Expand All @@ -153,10 +157,13 @@ public RetryAction shouldRetry(Exception exception, int retries,
// does not perform any failover.
// So Just retry with same OM node.
if (leaderNotReadyException != null) {
LOG.info("RetryProxy: {}",
leaderNotReadyException.getMessage());
retryExceptions.add(getExceptionMsg(leaderNotReadyException,
failovers));
if (LOG.isDebugEnabled()) {
LOG.debug("RetryProxy: {}", leaderNotReadyException.getMessage());
}
// HDDS-3465. OM index will not change, but LastOmID will be
// updated to currentOMId, so that wiatTime calculation will
// updated to currentOMId, so that waitTime calculation will
// know lastOmID and currentID are same and need to increment
// wait time in between.
omFailoverProxyProvider.performFailoverIfRequired(
Expand All @@ -169,13 +176,11 @@ public RetryAction shouldRetry(Exception exception, int retries,
// NotLeaderException fail over manually to the next OM Node proxy.
// OMFailoverProxyProvider#performFailover() is a dummy call and
// does not perform any failover.
String exceptionMsg;
if (exception.getCause() != null) {
exceptionMsg = exception.getCause().getMessage();
} else {
exceptionMsg = exception.getMessage();
retryExceptions.add(getExceptionMsg(exception, failovers));
if (LOG.isDebugEnabled()) {
LOG.debug("RetryProxy: {}", exception.getCause() != null ?
exception.getCause().getMessage() : exception.getMessage());
}
LOG.info("RetryProxy: {}", exceptionMsg);
omFailoverProxyProvider.performFailoverToNextProxy();
return getRetryAction(RetryDecision.FAILOVER_AND_RETRY, failovers);
}
Expand All @@ -186,9 +191,14 @@ private RetryAction getRetryAction(RetryDecision fallbackAction,
return new RetryAction(fallbackAction,
omFailoverProxyProvider.getWaitTime());
} else {
LOG.error("Failed to connect to OMs: {}. " +
"Attempted {} failovers.",
omFailoverProxyProvider.getOMProxyInfos(), maxFailovers);
StringBuilder allRetryExceptions = new StringBuilder();
allRetryExceptions.append("\n");
retryExceptions.stream().forEach(e -> allRetryExceptions.append(e));
LOG.error("Failed to connect to OMs: {}. Attempted {} failovers. " +
"Got following exceptions during retries: {}",
omFailoverProxyProvider.getOMProxyInfos(), maxFailovers,
allRetryExceptions.toString());
retryExceptions.clear();
return RetryAction.FAIL;
}
}
Expand All @@ -199,6 +209,22 @@ private RetryAction getRetryAction(RetryDecision fallbackAction,
return proxy;
}

private String getExceptionMsg(Exception e, int retryAttempt) {
StringBuilder exceptionMsg = new StringBuilder()
.append("Retry Attempt ")
.append(retryAttempt)
.append(" Exception - ");
if (e.getCause() == null) {
exceptionMsg.append(e.getClass().getCanonicalName())
.append(": ")
.append(e.getMessage());
} else {
exceptionMsg.append(e.getCause().getClass().getCanonicalName())
.append(": ")
.append(e.getCause().getMessage());
}
return exceptionMsg.toString();
}

/**
* Check if exception is OMLeaderNotReadyException.
Expand Down