HDDS-2321. Ozone Block Token verify should not apply to all datanode … #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/retest |
anuengineer
reviewed
Nov 2, 2019
Contributor
anuengineer
left a comment
anuengineer
left a comment
There was a problem hiding this comment.
I am +1, on this patch. Some minor comments in on this version.
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsUtils.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsUtils.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/token/BlockTokenVerifier.java
Outdated
Show resolved
Hide resolved
adoroszlai
reviewed
Nov 4, 2019
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
This fixes ozonesecure acceptance test, which has been consistently failing on master recently. Big thanks @xiaoyuyao for that.
Note that there are some CI issues introduced by this change:
- Failure of TestSecureContainerServer looks related.
- There are some checkstyle issues.
Contributor
Author
|
Thanks @adoroszlai and @anuengineer for the review. The unit test and checkstyle issues are fixed. |
Contributor
Author
|
/retest |
1 similar comment
Contributor
|
/retest |
Contributor
|
Thanks @xiaoyuyao for the update. Acceptance test failure is unrelated, it happens on master, too. Details: #11 (comment) Integration test failure is also unrelated, already tracked in Jira (HDDS-2367 and HDDS-2392). |
Contributor
Author
|
Thanks @adoroszlai for the confirmation. I will merge the PR shortly. |
ptlrs
pushed a commit
to ptlrs/ozone
that referenced
this pull request
Mar 8, 2025
…r Ozone to use downstream version of Solr. (apache#110)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2321
How was this patch tested?
Added Unit test testBlockTokenVerifier()
Update Unit test in TestSecureContainerServer.java
ozone secure smoke test.