Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Add a numeric suffix to Robot test output file names to avoid overwriting previous runs.

https://issues.apache.org/jira/browse/HDDS-3094

How was this patch tested?

Ran test in ozone-topology env, which calls readdata test twice (with different set of running datanodes).

$ cd hadoop-ozone/dist/target/ozone*/compose/ozone-topology
$ ./test.sh
...
Output:  /tmp/smoketest/ozone-topology/result/robot-ozone-topology-ozone-topology-readdata-scm.xml
...
Output:  /tmp/smoketest/ozone-topology/result/robot-ozone-topology-ozone-topology-readdata-scm-1.xml
...

https://github.com/adoroszlai/hadoop-ozone/runs/783624066

@adoroszlai adoroszlai self-assigned this Jun 18, 2020
Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Nice trick.

Merging to the master. Thanks the patch @adoroszlai

@elek elek merged commit 3c30f04 into apache:master Jun 22, 2020
@adoroszlai adoroszlai deleted the HDDS-3094 branch June 22, 2020 12:13
@adoroszlai
Copy link
Contributor Author

Thanks @elek for reviewing and committing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants