Skip to content

HDDS-3815. Avoid buffer copy in ContainerCommandRequestProto. #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dineshchitlangia merged 4 commits into from
Jun 23, 2020
Merged

HDDS-3815. Avoid buffer copy in ContainerCommandRequestProto. #1085

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81b06d5
HDDS-3815. Avoid buffer copy in ContainerCommandRequestProto.
mukul1987 Jun 17, 2020
a4d15c8
address checkstyle
mukul1987 Jun 17, 2020
a97a2b2
Update hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/ratis/…
mukul1987 Jun 22, 2020
e77a7d6
trigger new CI check
adoroszlai Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...dds/common/src/main/java/org/apache/hadoop/hdds/ratis/ContainerCommandRequestMessage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,11 @@ public static ContainerCommandRequestMessage toMessage(
public static ContainerCommandRequestProto toProto(
ByteString bytes, RaftGroupId groupId)
throws InvalidProtocolBufferException {
final int i = 4 + bytes.asReadOnlyByteBuffer().getInt();
final int i = Integer.BYTES + bytes.substring(0, Integer.BYTES)
.asReadOnlyByteBuffer().getInt();
final ContainerCommandRequestProto header
= ContainerCommandRequestProto.parseFrom(bytes.substring(4, i));
= ContainerCommandRequestProto
.parseFrom(bytes.substring(Integer.BYTES, i));
// TODO: setting pipeline id can be avoided if the client is sending it.
// In such case, just have to validate the pipeline id.
final ContainerCommandRequestProto.Builder b = header.toBuilder();
Expand Down