Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -97,19 +97,12 @@ private void constructColumnFamilyMap(DBDefinition dbDefinition) {

@Override
public Void call() throws Exception {
List<ColumnFamilyDescriptor> cfs = new ArrayList<>();
List<ColumnFamilyDescriptor> cfs =
RocksDBUtils.getColumnFamilyDescriptors(parent.getDbPath());

final List<ColumnFamilyHandle> columnFamilyHandleList =
new ArrayList<>();
List<byte[]> cfList = null;
cfList = RocksDB.listColumnFamilies(new Options(),
parent.getDbPath());
if (cfList != null) {
for (byte[] b : cfList) {
cfs.add(new ColumnFamilyDescriptor(b));
}
}
RocksDB rocksDB = null;
rocksDB = RocksDB.openReadOnly(parent.getDbPath(),
new ArrayList<>();
RocksDB rocksDB = RocksDB.openReadOnly(parent.getDbPath(),
cfs, columnFamilyHandleList);
this.printAppropriateTable(columnFamilyHandleList,
rocksDB, parent.getDbPath());
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.hadoop.ozone.debug;

import org.rocksdb.ColumnFamilyDescriptor;
import org.rocksdb.ColumnFamilyHandle;
import org.rocksdb.RocksDB;
import picocli.CommandLine;

import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.concurrent.Callable;

/**
* Drop a column Family/Table in db.
*/
@CommandLine.Command(
name = "drop_column_family",
description = "drop column family in db."
)
public class DropTable implements Callable<Void> {

@CommandLine.Option(names = {"--column_family"},
description = "Table name")
private String tableName;

@CommandLine.ParentCommand
private RDBParser parent;

@Override
public Void call() throws Exception {
List<ColumnFamilyDescriptor> cfs =
RocksDBUtils.getColumnFamilyDescriptors(parent.getDbPath());
final List<ColumnFamilyHandle> columnFamilyHandleList =
new ArrayList<>();
try (RocksDB rocksDB = RocksDB.open(
parent.getDbPath(), cfs, columnFamilyHandleList)) {
byte[] nameBytes = tableName.getBytes(StandardCharsets.UTF_8);
ColumnFamilyHandle toBeDeletedCf = null;
for (ColumnFamilyHandle cf : columnFamilyHandleList) {
if (Arrays.equals(cf.getName(), nameBytes)) {
toBeDeletedCf = cf;
break;
}
}
rocksDB.dropColumnFamily(toBeDeletedCf);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question:
If tablename is not a columnfamily in DB, we pass null for dropColumnFamily, do we need to print some error message if table is not in DB?

And also for the success scenario, do we want to add some message?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for the suggestion.

}
return null;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@
description = "Parse rocksdb file content",
subcommands = {
DBScanner.class,
ListTables.class
ListTables.class,
DropTable.class
})
public class RDBParser extends GenericCli {

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.hadoop.ozone.debug;

import org.rocksdb.ColumnFamilyDescriptor;
import org.rocksdb.Options;
import org.rocksdb.RocksDB;
import org.rocksdb.RocksDBException;

import java.util.ArrayList;
import java.util.List;

/**
* RocksDB specific utility functions.
*/
public final class RocksDBUtils {

/** Never constructed. **/
private RocksDBUtils() {
}

public static List<ColumnFamilyDescriptor> getColumnFamilyDescriptors(
String dbPath) throws RocksDBException {
List<ColumnFamilyDescriptor> cfs = new ArrayList<>();
List<byte[]> cfList = RocksDB.listColumnFamilies(new Options(), dbPath);
if (cfList != null) {
for (byte[] b : cfList) {
cfs.add(new ColumnFamilyDescriptor(b));
}
}
return cfs;
}
}