Skip to content

Conversation

@elek
Copy link
Member

@elek elek commented Jun 15, 2020

What changes were proposed in this pull request?

Description

Currently we have rocksdb 6.6.4 as major version and there are some jvm issues in tests (happened in #1019) related to rocksdb core dump. We may upgrade to 6.8.1 to avoid this issue.

JRE version: Java(TM) SE Runtime Environment (8.0_211-b12) (build 1.8.0_211-b12)

    Java VM: Java HotSpot(TM) 64-Bit Server VM (25.211-b12 mixed mode bsd-amd64 compressed oops)
    Problematic frame:
    C [librocksdbjni2954960755376440018.jnilib+0x602b8] rocksdb::GetColumnFamilyID(rocksdb::ColumnFamilyHandle*)+0x8

See full dump at https://the-asf.slack.com/files/U0159PV5Z6U/F0152UAJF0S/hs_err_pid90655.log?origin_team=T4S1WH2J3&origin_channel=D014L2URB6E(url)}}

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3776

How was this patch tested?

CI tests

@elek
Copy link
Member Author

elek commented Jun 15, 2020

Hmm. It worked during the test of unit test, but it seems that I need to update the API...

@codecov-commenter
Copy link

Codecov Report

Merging #1077 into master will decrease coverage by 0.08%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1077      +/-   ##
============================================
- Coverage     70.46%   70.38%   -0.09%     
+ Complexity     9242     9233       -9     
============================================
  Files           961      961              
  Lines         48130    48130              
  Branches       4676     4676              
============================================
- Hits          33917    33874      -43     
- Misses        11960    11999      +39     
- Partials       2253     2257       +4     
Impacted Files Coverage Δ Complexity Δ
...java/org/apache/hadoop/hdds/utils/db/RDBTable.java 57.33% <60.00%> (-4.00%) 19.00 <0.00> (-1.00)
...otocol/commands/RetriableDatanodeEventWatcher.java 55.55% <0.00%> (-44.45%) 3.00% <0.00%> (-1.00%)
...va/org/apache/hadoop/hdds/utils/db/RDBMetrics.java 85.71% <0.00%> (-7.15%) 13.00% <0.00%> (-1.00%)
.../transport/server/ratis/ContainerStateMachine.java 69.36% <0.00%> (-6.76%) 59.00% <0.00%> (-5.00%)
...ozone/container/ozoneimpl/ContainerController.java 63.15% <0.00%> (-5.27%) 11.00% <0.00%> (-1.00%)
...apache/hadoop/hdds/server/events/EventWatcher.java 77.77% <0.00%> (-4.17%) 14.00% <0.00%> (ø%)
...iner/common/statemachine/SCMConnectionManager.java 77.38% <0.00%> (-3.58%) 13.00% <0.00%> (-1.00%)
...iner/common/transport/server/ratis/CSMMetrics.java 67.69% <0.00%> (-3.08%) 19.00% <0.00%> (-1.00%)
...va/org/apache/hadoop/ozone/lease/LeaseManager.java 90.80% <0.00%> (-2.30%) 15.00% <0.00%> (-1.00%)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57a8388...e1b8af1. Read the comment docs.

Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1.

@timmylicheng
Copy link
Contributor

+1, Thanks Marton for making this commit.

@elek
Copy link
Member Author

elek commented Jun 17, 2020

Merged. Thanks the review @timmylicheng and @xiaoyuyao

@elek elek merged commit 73b87fd into apache:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants