Skip to content

HDDS-3679. Add unit tests for PipelineManagerV2. #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elek merged 1 commit into from
Jun 15, 2020
Merged

HDDS-3679. Add unit tests for PipelineManagerV2. #1019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...s/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineManagerV2Impl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,8 @@ public void openPipeline(PipelineID pipelineId) throws IOException {
}
if (pipeline.getPipelineState() == Pipeline.PipelineState.ALLOCATED) {
LOG.info("Pipeline {} moved to OPEN state", pipeline);
stateManager.updatePipelineState(pipelineId.getProtobuf(),
HddsProtos.PipelineState.PIPELINE_OPEN);
stateManager.updatePipelineState(
pipelineId.getProtobuf(), HddsProtos.PipelineState.PIPELINE_OPEN);
}
metrics.incNumPipelineCreated();
metrics.createPerPipelineMetrics(pipeline);
Expand Down Expand Up @@ -349,8 +349,8 @@ private void finalizePipeline(PipelineID pipelineId) throws IOException {
try {
Pipeline pipeline = stateManager.getPipeline(pipelineId);
if (!pipeline.isClosed()) {
stateManager.updatePipelineState(pipelineId.getProtobuf(),
HddsProtos.PipelineState.PIPELINE_CLOSED);
stateManager.updatePipelineState(
pipelineId.getProtobuf(), HddsProtos.PipelineState.PIPELINE_CLOSED);
LOG.info("Pipeline {} moved to CLOSED state", pipeline);
}

Expand Down
4 changes: 2 additions & 2 deletions ...ds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineStateManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,8 @@ public void removePipeline(HddsProtos.PipelineID pipelineIDProto)
}

@Override
public void updatePipelineState(HddsProtos.PipelineID pipelineIDProto,
HddsProtos.PipelineState newState)
public void updatePipelineState(
HddsProtos.PipelineID pipelineIDProto, HddsProtos.PipelineState newState)
throws IOException {
throw new IOException("Not supported.");
}
Expand Down
87 changes: 0 additions & 87 deletions .../server-scm/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelieManagerImpl.java
View file
Open in desktop

This file was deleted.

Loading