HDDS-2364. Add OM metrics to find the false positive rate for the keyMayExist. #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avijayanhwx
changed the title
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/db/RDBMetrics.java
Show resolved
Hide resolved
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/db/RDBTable.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
In this PR, my next commit will fix an issue in the isExist implementation, as discussed in #102 (review). |
added 2 commits
October 31, 2019 15:53
Contributor
Author
|
cc @anuengineer |
Contributor
bharatviswa504
left a comment
bharatviswa504
left a comment
There was a problem hiding this comment.
+1 LGTM.
I will wait for @anuengineer review, as @anuengineer has asked for few changes in keyMayExist logic.
maobaolong
reviewed
Dec 20, 2019
| StringBuilder outValue = new StringBuilder(); | ||
| boolean keyMayExist = db.keyMayExist(handle, key, outValue); | ||
| if (keyMayExist) { | ||
| boolean keyExists = (outValue.length() > 0) || |
Member
There was a problem hiding this comment.
Could you explain that why you need the addition condition to judge the value of keyMayExist? @avijayanhwx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added metrics for tracking the RocksDB keyMayExist miss rate. Fixed an issue in the Table.isExist() API such that we look at the out bound parameter that we pass in to rockdb.keyMayExist() before making a rockdb.get() call. The keyMayExist API usage was added in apache/hadoop#1013.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2364
How was this patch tested?
Unit tested.
Tested manually on cluster by looking at OzoneManager JMX endpoint.