Skip to content

Conversation

@dineshchitlangia
Copy link
Contributor

@dineshchitlangia dineshchitlangia commented Jun 1, 2020

What changes were proposed in this pull request?

reduced dn audit log:
As discussed in community call

  1. Reduce audit to Container related operations for all success + failure events and DELETE_BLOCK related events.
  2. Audit for all other operations (blocks, chunks etc) only on failures/errors.
  3. Addressed few sonar code smells.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3694

How was this patch tested?

Build and deployed 3 node cluster, created a few keys. Confirmed that DN audit log no longer logs for CHUNK/BLOCK related operations.

@dineshchitlangia
Copy link
Contributor Author

dineshchitlangia commented Jun 1, 2020

Failure is unrelated to patch, failed due to timeout.
Verified test passes in local and the fork.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dineshchitlangia for working on this.

Can this performance/security improvement be re-titled to clarify the change? I don't think this is a refactoring, since behavior is being changed.

@dineshchitlangia dineshchitlangia changed the title HDDS-3694. Refactor dn-audit log HDDS-3694. Reduce dn-audit log Jun 2, 2020
@adoroszlai
Copy link
Contributor

Thanks @dineshchitlangia for updating the patch.

@adoroszlai adoroszlai merged commit 1b09b63 into apache:master Jun 3, 2020
@dineshchitlangia
Copy link
Contributor Author

Thanks @adoroszlai for review/commit.

@dineshchitlangia dineshchitlangia deleted the HDDS-3694 branch June 3, 2020 15:49
isahekmat pushed a commit to isahekmat/hadoop-ozone that referenced this pull request Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants