ORC-546. Fix reading timestamps with duplicated millis within a second. #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasanthj
approved these changes
Aug 24, 2019
This caused SPARK-27594. Fixes apache#420 Signed-off-by: Owen O'Malley <[email protected]>
omalley
added a commit
that referenced
this pull request
Aug 26, 2019
This caused SPARK-27594. Fixes #420 Signed-off-by: Owen O'Malley <[email protected]>
omalley
added a commit
that referenced
this pull request
Aug 26, 2019
This caused SPARK-27594. Fixes #420 Signed-off-by: Owen O'Malley <[email protected]>
rdsr
pushed a commit
to linkedin/iceberg
that referenced
this pull request
Sep 10, 2019
* Remove workaround on timestamp nanos as per ORC-546: apache/orc#420 * Use ORC TypeDescription attributes for column mapping (cherry picked from commit 1b50f282403b281b1d09980c17a659ba6c46f5d9)
rdsr
pushed a commit
to linkedin/iceberg
that referenced
this pull request
Sep 24, 2019
* Remove workaround on timestamp nanos as per ORC-546: apache/orc#420 * Use ORC TypeDescription attributes for column mapping (cherry picked from commit 1b50f282403b281b1d09980c17a659ba6c46f5d9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the representation in TimestampColumnVector, which has two fields time (millis since 1970) and nanos (nanos within seconds). The problem came because the last 3 digits of time and top 3 digits of nanos both represent the millis. Before ORC-306, the last 3 digits of time were always 0. This patch restores that behavior.