ORC-1709: Upgrade GitHub Action setup-java to v4 and use built-in cache feature
#1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
setup-java to v4 and use built-in cache feature
|
cc @williamhyun |
williamhyun
reviewed
May 8, 2024
There was a problem hiding this comment.
Failed to save: Unable to reserve cache with key setup-java-Linux-maven-fc278625f3aefc0088ce0c0131f0800ddbf48815b63ee075e7d3fc5a9c1f392f, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/1925/merge, Key: setup-java-Linux-maven-fc278625f3aefc0088ce0c0131f0800ddbf48815b63ee075e7d3fc5a9c1f392f, Version: 3d88543681947283edf8997cb89a71c1522b2e39bc75c36ae780bd628eb8559d
Cache saved with the key: setup-java-Linux-maven-fc278625f3aefc0088ce0c0131f0800ddbf[4](https://github.com/apache/orc/actions/runs/8990923635/job/24698981632#step:9:4)8815b63ee075e7d3fc5a9c1f392f
@sullis
Is this working correctly?
|
Gentle ping for the above comment, @sullis . If we are not sure, let's revert |
|
Gentle ping, @sullis . |
dongjoon-hyun
requested changes
May 10, 2024
Interesting. I'd like to know if "Failed to save: Unable to reserve cache with key " is repeatable. Can you re-run the workflows? |
dongjoon-hyun
approved these changes
Aug 7, 2024
|
Do you have a JIRA ID? I can assign ORC-1709 to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
upgrade GitHub Action setup-java from v3 to v4
Also: setup-java supports a "cache" attribute. This allows us to remove the "cache" action from the workflow.
The "cache" attribute is documented in the setup-java README:
https://github.com/actions/setup-java/blob/main/README.md
Why are the changes needed?
v4 is the latest version of setup-java
How was this patch tested?
GitHub Actions workflow.
Was this patch authored or co-authored using generative AI tooling?
No.