-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ORC-1709: Upgrade GitHub Action setup-java
to v4 and use built-in cache feature
#1925
Conversation
setup-java
to v4 and use built-in cache feature
cc @williamhyun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failed to save: Unable to reserve cache with key setup-java-Linux-maven-fc278625f3aefc0088ce0c0131f0800ddbf48815b63ee075e7d3fc5a9c1f392f, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/1925/merge, Key: setup-java-Linux-maven-fc278625f3aefc0088ce0c0131f0800ddbf48815b63ee075e7d3fc5a9c1f392f, Version: 3d88543681947283edf8997cb89a71c1522b2e39bc75c36ae780bd628eb8559d
Cache saved with the key: setup-java-Linux-maven-fc278625f3aefc0088ce0c0131f0800ddbf[4](https://github.com/apache/orc/actions/runs/8990923635/job/24698981632#step:9:4)8815b63ee075e7d3fc5a9c1f392f
@sullis
Is this working correctly?
Gentle ping for the above comment, @sullis . If we are not sure, let's revert |
Gentle ping, @sullis . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we need to verify the validity, let's wait for the author's confirmation.
Interesting. I'd like to know if "Failed to save: Unable to reserve cache with key " is repeatable. Can you re-run the workflows? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Sorry for a long delay. I got a chance to revisit this PR today.
Merged to main.
Do you have a JIRA ID? I can assign ORC-1709 to you. |
What changes were proposed in this pull request?
upgrade GitHub Action setup-java from v3 to v4
Also: setup-java supports a "cache" attribute. This allows us to remove the "cache" action from the workflow.
The "cache" attribute is documented in the setup-java README:
https://github.com/actions/setup-java/blob/main/README.md
Why are the changes needed?
v4 is the latest version of setup-java
How was this patch tested?
GitHub Actions workflow.
Was this patch authored or co-authored using generative AI tooling?
No.