ORC-1665: Migrate to importOrder of spotless-maven-plugin
#1860
Conversation
cxzl25
changed the title
importOrder function in spotless-maven-pluginimportOrder function in spotless-maven-plugin
| @@ -330,4 +330,3 @@ private byte[] getMaterial() { | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
There was a problem hiding this comment.
Because these files have two newlines at the end, one newline is automatically deleted after spotless apply.
There was a problem hiding this comment.
Because these files have two newlines at the end, one newline is automatically deleted after spotless apply.
Please make a new PR for the end line change separately before all of these migration.
There was a problem hiding this comment.
Also, we need a way to prevent any future regression in terms of the end line.
There was a problem hiding this comment.
Please make a new PR for the end line change separately before all of these migration.
OK
we need a way to prevent any future regression in terms of the end line
Now spotless-maven-plugin will check this behavior, so the beginning of the CI failed at the beginning.
java/bench/core/src/java/org/apache/orc/bench/core/RecordCounters.java
Outdated
Show resolved
Hide resolved
dongjoon-hyun
changed the title
importOrder function in spotless-maven-pluginimportOrder of spotless-maven-plugin
### What changes were proposed in this pull request? This PR aims to remove extra newlines at the end of Java files. ### Why are the changes needed? #1860 (comment) ### How was this patch tested? GA ### Was this patch authored or co-authored using generative AI tooling? No Closes #1861 from cxzl25/ORC-1666. Authored-by: sychen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
|
Could you resolve the conflicts, @cxzl25 ? |
What changes were proposed in this pull request?
This PR aims to enable the
importOrderfunction inspotless-maven-plugin.Why are the changes needed?
Although there is now checkstyle to limit the order of imports, it cannot be automatically adjusted.
spotless-maven-plugincan check and automatically adjust.#1859 (review)
How was this patch tested?
local test
Was this patch authored or co-authored using generative AI tooling?
No