ORC-1520: Removed JDK 8 settings from pom #1639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paliwalashish
changed the title
dongjoon-hyun
approved these changes
Oct 24, 2023
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? The PR proposes to remove jdk8 related parameters from pom, since we moved to JDK 17 as part of apache#1627 ### Why are the changes needed? Since we moved to JDK 17, JDK 8 parameters are not relevant any more. This shall keep files up to date with changes ### How was this patch tested? Build runs successfully with the changes. Closes apache#1639 from mystic-lama/ORC-1520_remove_jdk8_settings. Lead-authored-by: mystic-lama <[email protected]> Co-authored-by: Yiqun Zhang <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The PR proposes to remove jdk8 related parameters from pom, since we moved to JDK 17 as part of #1627
Why are the changes needed?
Since we moved to JDK 17, JDK 8 parameters are not relevant any more.
This shall keep files up to date with changes
How was this patch tested?
Build runs successfully with the changes.