Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #5461

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Fix typo #5461

merged 1 commit into from
Feb 5, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 3, 2024

Description

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

Copy link
Member

@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b5c5d1) 75.84% compared to head (29baeca) 47.36%.

❗ Current head 29baeca differs from pull request most recent head 32b6bfe. Consider uploading reports for the commit 32b6bfe to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5461       +/-   ##
===========================================
- Coverage   75.84%   47.36%   -28.48%     
===========================================
  Files         241      234        -7     
  Lines       14649    14385      -264     
  Branches      629      625        -4     
===========================================
- Hits        11110     6814     -4296     
- Misses       3539     7571     +4032     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cclauss
Copy link
Contributor Author

cclauss commented Feb 3, 2024

Unit test changes copied from

@cclauss cclauss requested a review from style95 February 3, 2024 08:42
@cclauss
Copy link
Contributor Author

cclauss commented Feb 5, 2024

Rebased.

@style95 style95 merged commit 3f11fcc into apache:master Feb 5, 2024
6 checks passed
@style95
Copy link
Member

style95 commented Feb 5, 2024

@cclauss Thank you for the contribution!

@cclauss cclauss deleted the patch-14 branch February 5, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants