Make the test stable

[style95]

Description

This is to make the test stable.

Related issue and scope

• I opened an issue to propose and discuss this change (#????)

My changes affect the following components

• API
• Controller
• Message Bus (e.g., Kafka)
• Loadbalancer
• Scheduler
• Invoker
• Intrinsic actions (e.g., sequences, conductors)
• Data stores (e.g., CouchDB)
• Tests
• Deployment
• CLI
• General tooling
• Documentation

Types of changes

• Bug fix (generally a non-breaking change which closes an issue).
• Enhancement or new feature (adds new functionality).
• Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

• I signed an Apache CLA.
• I reviewed the style guides and followed the recommendations (Travis CI will check :).
• I added tests to cover my changes.
• My changes require further changes to the documentation.
• I updated the documentation where necessary.

[style95]

When ClientCreationCompleted is sent to the proxy before the data is updated, it causes a kind of cycle and the test keeps running.
https://github.com/apache/openwhisk/blob/master/core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerProxy.scala#L342

[bdoyle0182]

Was this test instability introduced recently? I know this is just a test, but I'm wondering if there could be an issue with this #5333 since I'm seeing weird orphaned non-existent containers in etcd

[style95]

Let me explain the details.

    case Event(ClientCreationCompleted(proxy), _: NonexistentData) =>
      self ! ClientCreationCompleted(proxy.orElse(Some(sender())))
      stay()

https://github.com/apache/openwhisk/blob/master/core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerProxy.scala#L342

According to this logic, if the proxy receives ClientCreationCompleted before the data becomes the ContainerCreatedData that comes from here, it repeatedly send the message to itself.
And it creates an akka message cycle.

Generally, it takes some time to create and initialize the activation client proxy.
It takes more than the time for a container proxy to receive the ContainerCreatedData.
So I believe there was no issue with this.

But in the test code, there is no client proxy initialization and it sent ClientCreationCompleted as soon as the proxy status changes. And it made a cycle according to the timing.

[bdoyle0182]

LGTM thanks for fixing this, seems like this is why I've been having trouble with the scheduler tests.

[style95]

I have no idea how it passed the scalaFmt in the previous PR.

[style95]

Even if it generally does not happen in production, it would be great to add a small delay to avoid the cycle as a last resort.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.45%. Comparing base (07c9202) to head (88887d5).
Report is 76 commits behind head on master.

Files with missing lines	Patch %	Lines
.../core/containerpool/v2/ActivationClientProxy.scala	33.33%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #5346       +/-   ##
===========================================
+ Coverage   38.96%   76.45%   +37.48%     
===========================================
  Files         240      240               
  Lines       14378    14383        +5     
  Branches      614      614               
===========================================
+ Hits         5602    10996     +5394     
+ Misses       8776     3387     -5389     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.