Use pureconfig for invoker/scheduler's basic http auth #5252
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5252 +/- ##
===========================================
- Coverage 70.76% 44.85% -25.92%
===========================================
Files 238 238
Lines 14009 14013 +4
Branches 567 543 -24
===========================================
- Hits 9914 6286 -3628
- Misses 4095 7727 +3632
Continue to review full report at Codecov.
|
| @@ -176,6 +176,8 @@ whisk { | |||
| } | |||
|
|
|||
| invoker { | |||
| username: "invoker.user" | |||
There was a problem hiding this comment.
Should there be an equivalent default config for the scheduler?
Also don't know off the top of my head but is . a special character for curl requests? Wouldn't want to make it harder to curl the invoker with a special character for those that don't care about creds and just using the default
There was a problem hiding this comment.
scheduler already has such config https://github.com/apache/openwhisk/blob/master/core/scheduler/src/main/resources/application.conf#L62-L63
and . is not special for curl:
[raja@localhost ansible]$ curl -u invoker.user:invoker.pass https://localhost:12001/isEnabled -k
{"enabled":true}
|
LGTM |
Replace hardcode username:password
Description
Related issue and scope
My changes affect the following components
Types of changes
Checklist: