Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default nodejs kind from nodejs:10 to nodejs:14 #5105

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

dgrove-oss
Copy link
Member

Node.js 10 hits its end of life on April 30, 2021. (https://nodejs.org/en/about/releases/)

Prepare for deprecation and eventual removal of the nodejs:10 kind by rolling the default for nodejs forward to nodejs:14 (most recent LTS release).

I propose to skip over nodejs:12 (similar to how we jumped from nodejs:6 to nodejs:10) since the change of a default kind (and associated stemcell change) is marginally disruptive.

@dgrove-oss
Copy link
Member Author

dgrove-oss commented Apr 20, 2021

Started a dev list discussion as well, since this is a non-trivial change. https://lists.apache.org/thread.html/r95425ad12cabdfbd0552df5768b0b7a260f3311bfe93e925f6d3f57f%40%3Cdev.openwhisk.apache.org%3E

@dgrove-oss dgrove-oss force-pushed the nodejs-default branch 3 times, most recently from 9a3342c to 3c72fb5 Compare April 21, 2021 15:10
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2021

Codecov Report

Merging #5105 (a1220ff) into master (f7ec9e3) will increase coverage by 36.45%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5105       +/-   ##
===========================================
+ Coverage   38.79%   75.25%   +36.45%     
===========================================
  Files         218      218               
  Lines       10700    10700               
  Branches      454      454               
===========================================
+ Hits         4151     8052     +3901     
+ Misses       6549     2648     -3901     
Impacted Files Coverage Δ
...nwhisk/core/scheduler/queue/ContainerCounter.scala 84.21% <0.00%> (-7.90%) ⬇️
.../scala/org/apache/openwhisk/core/entity/Exec.scala 90.62% <0.00%> (+1.56%) ⬆️
.../org/apache/openwhisk/core/entity/EntityPath.scala 100.00% <0.00%> (+1.88%) ⬆️
...la/org/apache/openwhisk/common/TransactionId.scala 94.11% <0.00%> (+2.35%) ⬆️
...e/openwhisk/core/containerpool/ContainerPool.scala 96.81% <0.00%> (+2.78%) ⬆️
.../org/apache/openwhisk/http/PoolingRestClient.scala 91.17% <0.00%> (+2.94%) ⬆️
...sk/core/containerpool/docker/DockerContainer.scala 95.60% <0.00%> (+3.29%) ⬆️
...tainerpool/docker/DockerClientWithFileAccess.scala 96.00% <0.00%> (+4.00%) ⬆️
...a/org/apache/openwhisk/core/entity/TimeLimit.scala 95.65% <0.00%> (+4.34%) ⬆️
...pache/openwhisk/core/containerpool/Container.scala 88.50% <0.00%> (+4.59%) ⬆️
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ec9e3...a1220ff. Read the comment docs.

@dgrove-oss dgrove-oss force-pushed the nodejs-default branch 2 times, most recently from 99734b9 to 5beea58 Compare April 21, 2021 17:56
@dgrove-oss dgrove-oss merged commit 87c8a98 into apache:master Apr 29, 2021
@dgrove-oss dgrove-oss deleted the nodejs-default branch April 29, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants