Copy JMX related files instead of moving to support jmx on k8s #5045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgle
commented
Jan 13, 2021
| # JMX auth files would be mounted as a symbolic link (read-only mode) | ||
| # with `root` privileges by the k8s secret. | ||
| cp -rL /conf/jmxremote.* /home/owuser | ||
| rm -f /conf/jmxremote.* 2>/dev/null || true |
There was a problem hiding this comment.
Note. The files can not be removed in the k8s because it's read-only mounted, so I hide the message and returns true. But in the default (Bare-metal, VM..) environment, the file can be removed.
bash-4.4$ rm -f jmxremote.*
rm: can't remove 'jmxremote.access': Resource busy
rm: can't remove 'jmxremote.password': Resource busy
| cp -rL /conf/jmxremote.* /home/owuser | ||
| rm -f /conf/jmxremote.* 2>/dev/null || true | ||
|
|
||
| # The owner must be `owuser` and the file only have read permission. | ||
| chmod 600 /home/owuser/jmxremote.* |
There was a problem hiding this comment.
Note. The mounted files (/conf/jmxremote.*) cannot be used directly, it's limitation of JMX.
If the auth file has permissions other than read, the following error occurs:
"Password file read access must be restricted"
rabbah
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JMX related auth files are mounted as a read-only mode by k8s secret.
(configMap and secrets volumeMount are always read-only by k8s.)
So, It can't use the
mvcommand in the copyJMXFiles.sh script.I'll open a new subsequent PR at the
apache/openwhisk-deploy-kuberepository for supporting JMX on the k8s environmentRelated issue and scope
No issues
My changes affect the following components
Types of changes
Checklist: