Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump nodejs6 from 6.9.1 to 6.11.3 #2746

Closed
wants to merge 1 commit into from

Conversation

jeremiaswerner
Copy link
Contributor

No description provided.

@rabbah
Copy link
Member

rabbah commented Sep 14, 2017

this or #2078 is a duplicate.

@csantanapr
Copy link
Member

I thought the discussion in the dev list https://lists.apache.org/thread.html/e882dd05f23dd7d313b00f520e7cb3c362636bba6a5d9112ec97a8a2@%3Cdev.openwhisk.apache.org%3E

Was leave nodejs:6 at 6.9.x and if we want a new version to create new kinds at the minor level 6.11.x resulting in a new runtime and kind nodejs:6.11 with the npm packages updated to the latest this allows to users/customers to have a bit of time to move from 6.9 to 6.11.

Allowing them to test in the new kind, with the new packages, and any node binary modules to be recompile for node 6.11.x

Copy link
Member

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a simple change in versions, but I think there is risk on braking in production actions, so a new kind and deprecating the old one I think is the path forward

@jeremiaswerner
Copy link
Contributor Author

@csantanapr I agree and close this PR.

@rabbah
Copy link
Member

rabbah commented Sep 14, 2017

thanks @jeremiaswerner and @csantanapr - should we wait to add new kinds until we've factored out the runtimes so we have a better build time story?

also, should #2078 be closed then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants