Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling #257

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Fix spelling #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/nodejsActionBase/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ function initializeActionHandler(message) {
let enableInitInstall= !process.env.OW_ENABLE_INIT_INSTALL ? 'true' : process.env.OW_ENABLE_INIT_INSTALL;

if (enableInitInstall === 'true') {
// install npm modules during init if source code zip doesn´t containt them
// install npm modules during init if source code zip doesn´t contain them
// check if package.json exists and node_modules don`t
if (fs.existsSync('package.json') && !fs.existsSync('./node_modules/')) {
var package_json = JSON.parse(fs.readFileSync('package.json', 'utf8'));
Expand Down
10 changes: 5 additions & 5 deletions docs/users/knative-build.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ NAME SECRETS AGE
openwhisk-runtime-builder 2 3m46s
```

## Install the BuildTemplate for the NodeJS runtime
## Install the BuildTemplate for the Node.js runtime

```
$ kubectl apply --filename buildtemplate.yaml
Expand Down Expand Up @@ -308,7 +308,7 @@ metadata:
```
</details>

## Building a Knative service using the NodeJS BuildTemplate
## Building a Knative service using the Node.js BuildTemplate

We will use the simple "helloworld" test case to demonstrate how to use Knative to Build your function into container image and then deploy it as a Service.

Expand Down Expand Up @@ -372,7 +372,7 @@ spec:
kubectl apply -f build.yaml
```

This creates a pod with a NodeJS runtime and all the action metadata (action code, main function name, etc) integrated into the container image. If for any reason there is a failure creating the pod, we can troubleshoot the deployment with:
This creates a pod with a Node.js runtime and all the action metadata (action code, main function name, etc.) integrated into the container image. If for any reason there is a failure creating the pod, we can troubleshoot the deployment with:

#### `kubectl get pods`

Expand Down Expand Up @@ -416,7 +416,7 @@ kubectl exec <build-pod-name> -- env

#### Configure service.yaml

Now that you have built the OpenWhisk NodeJS runtime image with the `helloworld` function "baked" into it, you can can deploy the image as a Knative Service.
Now that you have built the OpenWhisk Node.js runtime image with the `helloworld` function "baked" into it, you can deploy the image as a Knative Service.

You will need to configure the Service template to point to the Docker Hub repo. where your Knative OpenWhisk runtime (with the Hello World function) will be "pulled" from.

Expand Down Expand Up @@ -482,7 +482,7 @@ namespace "default" labeled
#### PROBLEM: Kubernetes and Istio resources do not all say "created" on "apply"

1. Verify that you have configured Docker Desktop to have the required CPU and Memory values recommended above.
2. Verify that all resources installed by applying either tha Knative or Istio YAML files show **"created"** during the installation.
2. Verify that all resources installed by applying either the Knative or Istio YAML files show **"created"** during the installation.
- If any of your resources were NOT **created**, then we recommend uninstalling Knative and Istio and trying again until you get the **created** result for all resources WITHOUT trying to apply a second time. Below is an example of successful creation of Knative resources:

<p>
Expand Down