Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply needle client #205

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Apply needle client #205

merged 2 commits into from
Feb 18, 2020

Conversation

KeonHee
Copy link
Member

@KeonHee KeonHee commented Feb 14, 2020 •
edited
Loading

  • Change request to needle
  • Install the necessary dependancies without relying on the default dependancies on node runtime.

@KeonHee KeonHee force-pushed the apply-needle-client branch 3 times, most recently from 92388e7 to 97d33b8 Compare February 17, 2020 02:09
@KeonHee KeonHee changed the title WIP: Apply needle client Apply needle client Feb 17, 2020
dgrove-oss
dgrove-oss approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgrove-oss dgrove-oss merged commit 11954a8 into apache:master Feb 18, 2020
@KeonHee KeonHee deleted the apply-needle-client branch February 19, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrove-oss dgrove-oss dgrove-oss approved these changes

@style95 style95 style95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KeonHee @style95 @dgrove-oss