Skip to content

fix(bindings/nodejs): ListOptions test list with deleted #6335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 1 commit into from
Jun 25, 2025
Merged

fix(bindings/nodejs): ListOptions test list with deleted #6335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions bindings/nodejs/tests/suites/asyncListOptions.suite.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,13 +158,14 @@ export function run(op) {
const filePath = path.join(dirname, `random_file_${randomUUID()}`)
await op.write(filePath, '1')

const lists = await op.list(dirname, { deleted: true })
const lists = await op.list(filePath, { deleted: true })
expect(lists.length).toBe(1)

await op.write(filePath, '2')
await op.remove(filePath)
await op.delete(filePath)

const actual = lists.filter((item) => item.path() === filePath && item.metadata().isDeleted())
const ds = await op.list(filePath, { deleted: true })
const actual = ds.filter((item) => item.path() === filePath && item.metadata().isDeleted())
expect(actual.length).toBe(1)

await op.removeAll(dirname)
Expand Down
7 changes: 4 additions & 3 deletions bindings/nodejs/tests/suites/syncListOptions.suite.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,13 +158,14 @@ export function run(op) {
const filePath = path.join(dirname, `random_file_${randomUUID()}`)
op.writeSync(filePath, '1')

const lists = op.listSync(dirname, { deleted: true })
const lists = op.listSync(filePath, { deleted: true })
expect(lists.length).toBe(1)

op.writeSync(filePath, '2')
op.removeSync(filePath)
op.deleteSync(filePath)

const actual = lists.filter((item) => item.path() === filePath && item.metadata().isDeleted())
const ds = op.listSync(filePath, { deleted: true })
const actual = ds.filter((item) => item.path() === filePath && item.metadata().isDeleted())
expect(actual.length).toBe(1)

op.removeAllSync(dirname)
Expand Down
Loading