Skip to content

Conversation

@kingsword09
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

#6324 modified the tmp_path value during append, but the value was inverted.

What changes are included in this PR?

Are there any user-facing changes?

@kingsword09 kingsword09 requested a review from Xuanwo as a code owner June 22, 2025 14:39
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels Jun 22, 2025
Copy link
Member

@erickguan erickguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry! I often forget fluid APIs changing the structure of if. Nice fix.

If you have investigated, is there an easy way to add a test for "append"?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 23, 2025
@erickguan erickguan merged commit a590b31 into apache:main Jun 24, 2025
104 checks passed
@erickguan
Copy link
Member

Thanks for the fix!

@kingsword09 kingsword09 deleted the fix-fs-append-error branch June 24, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants