feat(bindings/nodejs): Add WriteOptions support for new options API #6322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
dosubot
bot
added
the
releases-note/feat
Contributor
Author
|
The following attributes do not appear to be implemented yet and are inconsistent with the test case results, which will cause the test to fail:
|
kingsword09
commented
Jun 21, 2025
| const meta = await op.write(filenameA, contentA, { ifMatch: etagA }) | ||
| assert.instanceOf(meta, Metadata) | ||
|
|
||
| await expect(op.write(filenameA, contentA, { ifMatch: etagB })).rejects.toThrowError('ConditionNotMatch') |
Contributor
Author
There was a problem hiding this comment.
The ConditionNotMatch error is not thrown here, but the Metadata is returned.
kingsword09
commented
Jun 21, 2025
Contributor
Author
|
The same error occurs in the Rust tests within the core:
|
kingsword09
force-pushed
the
feat-nodejs-write-opts
branch
from
dcf4c82 to
5d87cb4
Compare
Member
Yep, not all s3 compatible services have the same feature. |
Member
|
Thank you @kingsword09 for working on this, I think we can resolve the conflicts and get ready for merging. |
kingsword09
force-pushed
the
feat-nodejs-write-opts
branch
from
5d87cb4 to
ea9613f
Compare
Contributor
Author
Merged! |
Xuanwo
approved these changes
Jul 11, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @kingsword09 for working on this, really great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #6281.
Rationale for this change
This PR adds support for opendal::options::WriteOptions conversion in the nodejs bindings. This is part of the migration to the new options API outlined in RFC-6213 (#6213).
What changes are included in this PR?
Are there any user-facing changes?
Yes, users can now add options to their write requests