Skip to content

Conversation

@kingsword09
Copy link
Contributor

Which issue does this PR close?

Related to #6281.

Rationale for this change

This PR adds support for opendal::options::ListOptions conversion in the nodejs bindings. This is part of the migration to the new options API outlined in RFC-6213 (#6213).

What changes are included in this PR?

  • Added a complete mapping and conversion of opendal::options::ListOptions
  • behavior tests mirroring Rust's async_list.rs test suite
  • Added the capabilities to support the options

Are there any user-facing changes?

Yes, users can now add options to their list requests

@kingsword09 kingsword09 requested a review from suyanhanx as a code owner June 20, 2025 14:02
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels Jun 20, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this change, thank you @kingsword09 for working on this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 25, 2025
@Xuanwo Xuanwo merged commit e6be561 into apache:main Jun 25, 2025
100 checks passed
@kingsword09 kingsword09 deleted the feat-nodejs-list-opts branch July 13, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants