Skip to content

Conversation

@geruh
Copy link
Contributor

@geruh geruh commented Jun 1, 2025

Which issue does this PR close?

Related to #6226.

Rationale for this change

This PR adds support for the rest of the ListOptions and migrates the rest of them to use the new options API support in Java bindings as part of the migration to the new options API outlined in RFC-6213 (#6213).

What changes are included in this PR?

  • Extended the java capabilities to include the required listing capabilities for the rest of the list options
  • Added a complete mapping and conversion of theopendal::options::ListOptions and the Java ListOptions class.

Are there any user-facing changes?

Yes, added the rest of ListOptions: limit, startAfter, versions, deleted

@geruh geruh requested a review from tisonkun as a code owner June 1, 2025 19:52
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels Jun 1, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect changes!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 2, 2025
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM.

@tisonkun tisonkun merged commit 7c6e970 into apache:main Jun 2, 2025
66 checks passed
@geruh geruh deleted the list-options branch June 2, 2025 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants