feat(bindings/java): Add WriteOptions support for new options API #6219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
geruh
commented
May 26, 2025
| env: &mut JNIEnv<'a>, | ||
| options: &JObject, | ||
| ) -> Result<opendal::options::WriteOptions> { | ||
| let concurrent = match convert::read_int_field(env, options, "concurrent")? { |
Contributor
Author
There was a problem hiding this comment.
Added input validation to prevent negative values that would cause capacity overflow when casting to usize. negative i32/i64 values wrap to huge positive usize values
5 tasks
tisonkun
approved these changes
May 29, 2025
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #6214.
Rationale for this change
This PR implements WriteOptions support in Java bindings as part of the migration to the new options API outlined in RFC-6213 (#6213). This is the first step in migrating Java bindings to use the new options APIs, starting with write operations. Although if you rather have all options migrated in one go we can close.
What changes are included in this PR?
Added a complete mapping and conversion of the
opendal::options::WriteOptionsand the Java WriteOptions class.Are there any user-facing changes?
no, but I added the ability to handle chunking, and concurrency options to match opt api.
Let me know if this is the right direction!