Skip to content

feat(java): add WriteOptions for write methods #5664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xuanwo merged 4 commits into from
Mar 3, 2025
Merged

feat(java): add WriteOptions for write methods #5664

Xuanwo merged 4 commits into from
Mar 3, 2025

Conversation

@geruh
Copy link
Contributor

@geruh geruh commented Feb 26, 2025 •
edited
Loading

Which issue does this PR close?

Closes #5651.

Rationale for this change

This is a draft as a possibility to add conditional writes to the java bindings with write options

What changes are included in this PR?

introduce write options to the exposed write_with method in rust

Are there any user-facing changes?

yes

@geruh geruh requested a review from tisonkun as a code owner February 26, 2025 08:49
@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Feb 26, 2025
tisonkun
tisonkun reviewed Feb 26, 2025
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The binding part looks generally in a good direction.

@Xuanwo you may give a review on the native part. That said, src/async_operator.rs's changes.

tisonkun
tisonkun approved these changes Mar 1, 2025
View reviewed changes
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution @geruh!

Would you fix up the license issue and other CI failure? They should be straightforward.

Xuanwo
Xuanwo reviewed Mar 1, 2025
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, thank you @geruh!

@Xuanwo
Copy link
Member

Xuanwo commented Mar 1, 2025

I also started a discussion about the issue I encountered in this PR: #5674

@geruh geruh requested a review from Xuanwo March 3, 2025 00:56
@Xuanwo
Copy link
Member

Xuanwo commented Mar 3, 2025

Hi, @geruh, this PR is almost ready to go. We are waiting for a fix on main branch to bring our CI back.

@Xuanwo Xuanwo merged commit 0c44e07 into apache:main Mar 3, 2025
183 checks passed
This was referenced Mar 9, 2025
Merged
Closed
@alexr17 alexr17 mentioned this pull request Mar 11, 2025
Merged
4 tasks
@Xuanwo Xuanwo mentioned this pull request Mar 20, 2025
Closed
1 task
@tisonkun tisonkun mentioned this pull request May 10, 2025
Closed
@hudi-bot hudi-bot mentioned this pull request Nov 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tisonkun tisonkun tisonkun approved these changes

@Xuanwo Xuanwo Awaiting requested review from Xuanwo

Assignees

No one assigned

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

new feature: Expose conditional writes for Java bindings

3 participants

@geruh @Xuanwo @tisonkun