-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add codspeed for benchmark #4993
base: main
Are you sure you want to change the base?
Conversation
uses: CodSpeedHQ/action@v3 | ||
with: | ||
run: cargo codspeed run | ||
token: ${{ secrets.CODSPEED_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please load from 1password.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will use 1password after I get the token. Thanks for the review.
Hi, @adriencaccia, OpenDAL has a benchmark suite that can run tests over different services based on the environment. Does Codspeed support our case? For example, running Cargo Codspeed multiple times can display their performance in groups based on service. |
Hey, at the moment there is no support for grouping benchmarks. |
Hi, @adriencaccia, there are some concerns from the ASF INFRA, do you have comments? |
Hey, I just answered in apache/arrow-rs#6150 (comment) 😉 |
Thanks! |
Which issue does this PR close?
Closes #4937 .
Rationale for this change
Trying to add a benchmark workflow to track and compare performance
What changes are included in this PR?
A new workflow that runs on every PR and the default main branch.
The criterion dependency is changed to codspeed-criterion-compat.
This should not affect
cargo bench
Are there any user-facing changes?
No
Wait for approval from infra team https://issues.apache.org/jira/projects/INFRA/issues/INFRA-26030?filter=allissues