refactor(core): move move logic from fn metadata(&self) -> Arc<AccessorInfo> to impl<A: Access> Layer<A> for CompleteLayer #4896
Conversation
Signed-off-by: Lzzzt <[email protected]>
Signed-off-by: Lzzzt <[email protected]>
Signed-off-by: Lzzzt <[email protected]>
core/src/layers/complete.rs
Outdated
| @@ -382,7 +389,7 @@ impl<A: Access> LayeredAccess for CompleteAccessor<A> { | |||
|
|
|||
| // Todo: May move the logic to the implement of Layer::layer of CompleteAccessor<A> | |||
| fn metadata(&self) -> Arc<AccessorInfo> { | |||
| let mut meta = (*self.meta).clone(); | |||
| let mut meta = self.meta.as_ref().clone(); | |||
| let cap = meta.full_capability_mut(); | |||
| if cap.list && cap.write_can_empty { | |||
There was a problem hiding this comment.
Maybe we can remove those code and the comment?
There was a problem hiding this comment.
if we do this, the issue #4888 is not resolved....
There was a problem hiding this comment.
if we do this, the issue #4888 is not resolved....
Could you elaborate further? I'm not sure which issue remains unresolved.
There was a problem hiding this comment.
Maybe we can remove those code and the comment?
you means delete the
// Todo: May move the logic to the implement of Layer::layer of CompleteAccessor<A>
and
let mut meta = self.meta.as_ref().clone();
?
There was a problem hiding this comment.
Yep, since we have created the Arc<AccessInfo> during layer(), we can remove the dup code here.
There was a problem hiding this comment.
that's my problem, sry.
Signed-off-by: Hanchin Hsieh <[email protected]>
* feat(user_metadata): support user defined metadata for oss * fix cargo fmt && doc tests * Add user metadata key checks for oss && refeactor some code * remove unused code
Signed-off-by: Lzzzt <[email protected]>
|
The C/C++ test failed, which is a bit weird. I'll try to figure out what happened. I'm guessing it's related to our |
Which issue does this PR close?
Closes #4888
What changes are included in this PR?
mentioned in #4888
Are there any user-facing changes?
No