Skip to content

feat(services/s3): Return error if credential is empty after loaded #4000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xuanwo merged 1 commit into from
Jan 17, 2024
Merged

feat(services/s3): Return error if credential is empty after loaded #4000

Xuanwo merged 1 commit into from
Jan 17, 2024

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 17, 2024

No description provided.

@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jan 17, 2024
suyanhanx
suyanhanx approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xuanwo Xuanwo merged commit b2c59eb into main Jan 17, 2024
@Xuanwo Xuanwo deleted the fix-anonymous branch January 17, 2024 05:07
@Zheaoli Zheaoli mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@silver-ymz silver-ymz Awaiting requested review from silver-ymz

Assignees

No one assigned

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Xuanwo @suyanhanx