docs(bindings/nodejs): copyright in footer #3986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: suyanhanx <[email protected]>
github-actions
bot
added
the
releases-note/docs
Signed-off-by: suyanhanx <[email protected]>
tisonkun
approved these changes
Jan 15, 2024
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Thank you!
Out of the thread, do we have to check in the lockfile for nodejs binding? IIRC libraries are better not to include lockfile, or it's applied only for Cargo crates.
Member
Author
For JavaScript libs, I think it is better to include it. Without it, it's hard to ensure everyone would get the same dependencies installed for development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add copyright to the doc's footer