Skip to content

feat(core): Allow retry in concurrent write operations #3958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xuanwo merged 9 commits into from
Jan 10, 2024
Merged

feat(core): Allow retry in concurrent write operations #3958

Xuanwo merged 9 commits into from
Jan 10, 2024

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 9, 2024

Fix #3956

@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 9, 2024

cc @WenyXu for review.

@Xuanwo
Fix typo
0e95340 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo mentioned this pull request Jan 9, 2024
Closed
@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 9, 2024

GitHub issue caused CI failure.

@WenyXu
Copy link
Member

WenyXu commented Jan 9, 2024 •
edited
Loading

LGTM. Let's add some tests in the future to ensure the retry behaviors.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 10, 2024

LGTM. Let's add some tests in the future to ensure the retry behaviors.

Yep, I did found more problems..

@Xuanwo Xuanwo requested review from PsiACE, asf-ci, dqhl76, oowl and suyanhanx and removed request for asf-ci January 10, 2024 07:14
@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jan 10, 2024
@Xuanwo
FIx
f8a12b0 
Signed-off-by: Xuanwo <[email protected]>
@oowl
Copy link
Member

oowl commented Jan 10, 2024

It seems our google driver test key has been revoked. LOL

   "error": "invalid_grant",
  "error_description": "Token has been expired or revoked."

@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 10, 2024

It seems our google driver test key has been revoked. LOL

Yep, it's expired. Not related to this PR.

oowl
oowl approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@oowl oowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! wait for our CI test problem to be addressed.

@Xuanwo Xuanwo merged commit 8315b7e into main Jan 10, 2024
@Xuanwo Xuanwo deleted the fix-retry branch January 10, 2024 07:50
@Zheaoli Zheaoli mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oowl oowl oowl approved these changes

@suyanhanx suyanhanx Awaiting requested review from suyanhanx

@PsiACE PsiACE Awaiting requested review from PsiACE

@dqhl76 dqhl76 Awaiting requested review from dqhl76

Assignees

No one assigned

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: Concurrent writes should return immediately without retry

3 participants

@Xuanwo @WenyXu @oowl