Skip to content

Conversation

@WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 2, 2024

Add concurrent writer RFC

Related issue

@github-actions github-actions bot added the releases-note/feat The PR implements a new feature or has a title that begins with "feat" label Jan 2, 2024
@WenyXu WenyXu force-pushed the rfc/concurrent-write branch from 7d82dc2 to f2e44e5 Compare January 2, 2024 15:15
@WenyXu WenyXu force-pushed the rfc/concurrent-write branch from f2e44e5 to 4409194 Compare January 2, 2024 15:16
@WenyXu WenyXu marked this pull request as ready for review January 2, 2024 15:18
@WenyXu WenyXu requested a review from Xuanwo as a code owner January 2, 2024 15:18
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This RFC is great overall! But I don't like the tone to only talking about OpenDAL's Raw API (multipart upload). Users need not be aware of the multipart upload process; it is an internal detail exclusively for developers.

@Xuanwo Xuanwo changed the title feat: add concurrent writer RFC RFC-3898: Concurrent Writer Jan 2, 2024
@WenyXu WenyXu marked this pull request as draft January 3, 2024 09:38
@WenyXu WenyXu marked this pull request as ready for review January 3, 2024 16:11
@WenyXu WenyXu marked this pull request as draft January 4, 2024 04:12
@WenyXu WenyXu marked this pull request as ready for review January 4, 2024 04:47
@WenyXu
Copy link
Member Author

WenyXu commented Jan 4, 2024

Thanks a lot, @Xuanwo. I always learn a lot when cooperating with you. Feel free to let me know if I can improve anything 🚀

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's move!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants