Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Rewrite cpp binding by pimpl #3584

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[WIP] Rewrite cpp binding by pimpl #3584

wants to merge 8 commits into from

Commits on Nov 18, 2023

  1. Refactor Metadata 

    Signed-off-by: Jack Drogon <[email protected]>
    @JackDrogon
    JackDrogon committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    e36611d View commit details
    Browse the repository at this point in the history

  2. Split Metadata class into metadata.hpp && metadata.cc 

    Signed-off-by: Jack Drogon <[email protected]>
    @JackDrogon
    JackDrogon committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    ba8cff9 View commit details
    Browse the repository at this point in the history

  3. Impl all previous Metadata api 

    Signed-off-by: Jack Drogon <[email protected]>
    @JackDrogon
    JackDrogon committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    0ab9ae1 View commit details
    Browse the repository at this point in the history

  4. Add nodiscard && noexcept attributes in Metadata 

    Signed-off-by: Jack Drogon <[email protected]>
    @JackDrogon
    JackDrogon committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    279d3b9 View commit details
    Browse the repository at this point in the history

  5. Split all class in standalone header 

    Signed-off-by: Jack Drogon <[email protected]>
    @JackDrogon
    JackDrogon committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    d2a06f1 View commit details
    Browse the repository at this point in the history

  6. Spilit Reader impl into reader.cpp 

    Signed-off-by: Jack Drogon <[email protected]>
    @JackDrogon
    JackDrogon committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    38f1928 View commit details
    Browse the repository at this point in the history

  7. Split all class into standalone file && remove opendal.cpp 

    Signed-off-by: Jack Drogon <[email protected]>
    @JackDrogon
    JackDrogon committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    b94d3b6 View commit details
    Browse the repository at this point in the history

  8. Refactor Lister 

    Signed-off-by: Jack Drogon <[email protected]>
    @JackDrogon
    JackDrogon committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    cf59ad8 View commit details
    Browse the repository at this point in the history