Skip to content

Conversation

@tisonkun
Copy link
Member

No description provided.

@tisonkun tisonkun requested review from PsiACE and Xuanwo as code owners August 26, 2023 00:47
@github-actions github-actions bot added the releases-note/ci The PR modifies CI-related content or has a title that begins with "ci" label Aug 26, 2023
@tisonkun
Copy link
Member Author

Waiting for approval - https://issues.apache.org/jira/browse/INFRA-24928

We need this action to set up protoc on all platforms instead of manually tweaks.

Signed-off-by: tison <[email protected]>
@tisonkun
Copy link
Member Author

@Xuanwo we can proeprly staging the artifacts now!

But I noticed that the staged osx_aarch64 JAR contains x86_64's dylib. I'm digging into the details and will remove the debugging trick before calling a merge.

@tisonkun
Copy link
Member Author

@Xuanwo @suyanhanx This is ready for review now!

Comment on lines +21 to +26
push:
tags:
# Staging JARs on Apache Nexus repository for RCs. Read more on
# https://opendal.apache.org/docs/contributing/release#release-maven-artifacts
- 'v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+'
workflow_dispatch:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few thoughts on these triggers:

  1. I keep the workflow_dispatch so that we can somehow debug the workflow. It's possible that we retain only this trigger and let the RM trigger release staging on a tag manually. But let's try to do it fully automatically now.
  2. For the tag triggers:

I create a pattern that only staging for each RC. This is because we only staging the artifacts instead of fire the release. The staging artifacts can be found at https://repository.apache.org/#stagingRepositories. For example, the last commit debugging commit staging orgapacheopendal-1012:

image

I'll click "Drop" to clean up. And a RM should "Drop" on vote failed; "Close" and later "Release" on vote passed.

Note that since we tag -rcN Git tags now, other bindings releases should filter out the trigger on RCs, or following the process here to staging on RCs.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Let's go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/ci The PR modifies CI-related content or has a title that begins with "ci"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants