NIFI-14346 PutDatabaseRecord fails to do upsert on MySQL due to too few parameters bound

[TomaszK-stack]

This change addresses an issue in the PutDatabaseRecord processor when the Statement Type is set to UPSERT and connected to a MySQL database. The original code for binding parameters to the UPSERT SQL statement was incorrectly calculating the number of repetitions for parameter setting, leading to the error: java.sql.SQLException: No value specified for parameter 1.

Summary

NIFI-14346

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
  • JDK 21

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[dan-s1]

@TomaszK-stack Thank you for contributing your change. Can you please keep the basic template of the PR where there should be a link to associated ticket? Also a title would help describing your fix. Thanks!

[exceptionfactory]

@TomaszK-stack, concurring with @dan-s1, please update the pull request title and use the pull request template. The background description is very helpful, and can be preserved along with the standard template.

For the functional change itself, it would be very helpful to add a unit test to confirm the behavior. There are a number of existing tests that should provide a useful starting point.

[TomaszK-stack]

Okay, I changed title of pr and description - now is along with standard template.
I considered writing unit tests but there but It would be hard to test working upsert on special database like MySql in this case.