Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13763 HashSet filtering can not be set for DeduplicateRecord pro… #9277

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

timeabarna
Copy link
Contributor

@timeabarna timeabarna commented Sep 19, 2024

…cessor

The following calculation determines which filtering method should be used:

boolean useHashSet = context.getProperty(FILTER_TYPE).getValue()
.equals(context.getProperty(HASH_SET_VALUE.getValue()).getValue());

As HASH_SET_VALUE is an Allowable value not a PropertyDescriptor, this boolean will always be false, so in all cases Bloom Filter will be used.

NIFI-13763

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and resolving this issue @timeabarna! +1 merging

@exceptionfactory exceptionfactory merged commit e125d8c into apache:main Sep 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants