Skip to content

NIFI-16189 Deprecated StreamUtils#read(InputStream,byte[] destination, int) #11533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
exceptionfactory merged 1 commit into from
Aug 12, 2026
Merged

NIFI-16189 Deprecated StreamUtils#read(InputStream,byte[] destination, int) #11533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/StreamUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ public static int fillBuffer(final InputStream source, final byte[] destination,
* @throws IllegalArgumentException if the given byte array is smaller than <code>byteCount</code> elements.
* @throws EOFException if the InputStream does not have <code>byteCount</code> bytes in the InputStream
* @throws IOException if unable to read from the InputStream
* @deprecated Use {@link InputStream#readNBytes(byte[], int, int)} instead.
*/
@Deprecated(since = "2.12.0", forRemoval = true)
public static void read(final InputStream source, final byte[] destination, final int byteCount) throws IOException {
if (destination.length < byteCount) {
throw new IllegalArgumentException();
Expand Down
7 changes: 3 additions & 4 deletions ...i-network-processors/src/main/java/org/apache/nifi/processors/network/pcap/SplitPCAP.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import org.apache.nifi.processor.exception.ProcessException;
import org.apache.nifi.processor.io.InputStreamCallback;
import org.apache.nifi.processor.util.StandardValidators;
import org.apache.nifi.stream.io.StreamUtils;

import java.io.BufferedInputStream;
import java.io.IOException;
Expand Down Expand Up @@ -196,7 +195,7 @@ public PCAPStreamSplitterCallback(ProcessSession session, FlowFile flowFile, int

private Packet getNextPacket(final BufferedInputStream bufferedStream, final PCAP templatePcap, final int totalPackets) throws IOException {
final byte[] packetHeader = new byte[Packet.PACKET_HEADER_LENGTH];
StreamUtils.read(bufferedStream, packetHeader, Packet.PACKET_HEADER_LENGTH);
bufferedStream.readNBytes(packetHeader, 0, Packet.PACKET_HEADER_LENGTH);

final Packet currentPacket = new Packet(packetHeader, templatePcap);

Expand All @@ -206,7 +205,7 @@ private Packet getNextPacket(final BufferedInputStream bufferedStream, final PCA

final int expectedLength = (int) currentPacket.expectedLength();
final byte[] packetBody = new byte[expectedLength];
StreamUtils.read(bufferedStream, packetBody, expectedLength);
bufferedStream.readNBytes(packetBody, 0, expectedLength);
currentPacket.setBody(packetBody);

if (currentPacket.isInvalid()) {
Expand All @@ -227,7 +226,7 @@ public void process(final InputStream inStream) throws IOException {
}

final byte[] pcapHeader = new byte[PCAPHeader.PCAP_HEADER_LENGTH];
StreamUtils.read(bufferedStream, pcapHeader, PCAPHeader.PCAP_HEADER_LENGTH);
bufferedStream.readNBytes(pcapHeader, 0, PCAPHeader.PCAP_HEADER_LENGTH);

int currentPcapTotalLength = PCAPHeader.PCAP_HEADER_LENGTH;

Expand Down
2 changes: 1 addition & 1 deletion ...n/java/org/apache/nifi/controller/queue/clustered/server/StandardLoadBalanceProtocol.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ private void verifyChecksum(final Checksum checksum, final InputStream in, final

private long readChecksum(final InputStream in) throws IOException {
final byte[] buffer = getDataBuffer();
StreamUtils.read(in, buffer, 8);
in.readNBytes(buffer, 0, 8);
return ByteBuffer.wrap(buffer, 0, 8).getLong();
}

Expand Down
Loading