NIFI-12541 - Add a mobile menu to the NiFi site for smaller screens #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a mobile offcanvas menu and a hamburger button that shows up at a custom breakpoint. Restyled download links to look better on mobile Fixed some odd table behavior on mobile and desktop
exceptionfactory
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Thanks for adding support for the off-canvas menu on mobile screens @james-elliott, the changes look good! +1 merging
exceptionfactory
pushed a commit
that referenced
this pull request
Dec 22, 2023
Added a mobile offcanvas menu and a hamburger button that shows up at a custom breakpoint. Restyled download links to look better on mobile Fixed some odd table behavior on mobile and desktop This closes #80 Signed-off-by: David Handermann <[email protected]>
|
Merged to main-staging in commit cc0af16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a mobile offcanvas menu and a hamburger button that shows up at a custom breakpoint.
Restyled download links to look better on mobile
Fixed some odd table behavior on mobile and desktop