Fixing ProjectReload with missing artifacts #7855
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
Maven
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered that if
ProjectReload.withProjectStateis used and the project contains a truly unresolvable artifact (i.e. a reference to a local custom build, that can be never downloaded), the priming support will keep telling the project state is not good. The past priming information (with an old timestamp) was incorrectly cached and has been merged with the new MavenProject, but degraded its timestamp ... so it was older than constituent files, which resulted in an inconsistent state right after load.This PR extends the SPI to indicate that the ReloadImplementation should execute whenever previous ReloadImplementations changed anything. It also fixes various conditions with missing artifacts and project (re)loads - see the added test cases.